my first recording was in 1986 in Australia, from my experience producers are fuckn RARE...good producers are even more difficult to find...most commonly I find "engineers" calling themselves producers and whats more disappointing is that they only specialized in a particular type of instrument or they favor that instrument because of their background.
Example the guitarist who becomes a "producer"...he gets a good guitar tone - (great your still an engineer btw), but lacks in the other instruments and couldn't give a flying tit-fuck about the importance of the bass etc (yes venting).
Performance....hitting record and saying "again" does not constitute a producer, reading newspaper, texting, taking phone calls while someone is tracking is not a producer. With the performance I expect the producer to be able to articulate what is wrong and how to improve it, "again" or "play less gay" or "thats fucked" are not supportive of any player, I expect "try this", "you've got a better take in you", "hey come back tomorrow and practice X, Y, Z" or worst case "let rebook you after you do X, Y, Z"
The Song....Metal heads are stubborn cunts, we know everything and have written a couple of books on it
, it's takes a lot of energy and experience on the producers behalf to work with a band. When recording its all about the "song", Structures (Verse, Bridge, Outro), Dynamics (crescendo, Fortissimo, Forte), Lyrics - A real producer will work on the lyrics with the vocalist, the pronunciation and delivery, the number of words shoved into a verse etc, from my experience only a very few producers will get involved at the "song" level, most commonly they will just do the thing they do best (engineer) and hit record.....